Give Setup webview a single section #3448
Conversation
mattseddon
force-pushed
the
give-setup-section
branch
from
fc5aa0e to
b8fd6ab
Compare
mattseddon
force-pushed
the
give-setup-section
branch
from
b8fd6ab to
83c032e
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (!hasData) { | ||
| return <NoData /> |
There was a problem hiding this comment.
Avoid too many return statements within this function.
| } | ||
|
|
||
| if (hasData === undefined) { | ||
| return <EmptyState>Loading Project...</EmptyState> |
There was a problem hiding this comment.
Avoid too many return statements within this function.
| return <NoData /> | ||
| } | ||
|
|
||
| return <EmptyState>{"You're all setup"}</EmptyState> |
There was a problem hiding this comment.
Avoid too many return statements within this function.
| pythonBinPath: string | undefined | ||
| } | ||
|
|
||
| export const SetupExperiments: React.FC<SetupExperimentsProps> = ({ |
There was a problem hiding this comment.
Function SetupExperiments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
| return <CliIncompatible checkCompatibility={checkCompatibility} /> | ||
| } | ||
|
|
||
| if (cliCompatible === undefined) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| @@ -8,3 +8,13 @@ export type SetupData = { | |||
| projectInitialized: boolean | |||
| pythonBinPath: string | undefined | |||
| } | |||
|
|
|||
| export enum Section { | |||
There was a problem hiding this comment.
Should we make this enum name unique (as well as the one in plot)? Importing after typing only section might be confusing if the wrong Section is imported.
There was a problem hiding this comment.
I actually got hit by this already. I will update after #3452.
|
Code Climate has analyzed commit 916e1a9 and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 92.5% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.7% (0.1% change). View more on Code Climate. |
2/2
main<- #3440 <- thisThis is exactly the same PR as #3441 which was merged in error. I have manually reverted that changed and replaced it with this PR.
This PR uses the shared component created in #3440 to give the Setup webview a single section.
Demo
Screen.Recording.2023-03-10.at.3.26.06.pm.mov
Note: This looks odd now but there will be a section above for the walkthrough and one below for Studio. I will also condense the
EmptyStates toEmptySections (isFullScreen=false)